| commit | 1fe7707cf04852d024b64f695e40568696851b15 | [log] [tgz] |
|---|---|---|
| author | Ghanshyam Mann <gmann@ghanshyammann.com> | Tue Mar 05 08:30:19 2024 -0800 |
| committer | Ghanshyam Mann <gmann@ghanshyammann.com> | Tue Mar 05 08:37:03 2024 -0800 |
| tree | c69a565ba307b92d1dbbefa6c80e870b6cf237e4 | |
| parent | 57c685496f0ef8da0d6ebc50845f752caf29948a [diff] |
Ignore 500 status code in generate plugin script Due to various reasons, this script may encounter the 500 status code from some repo (x/fuel-plugin-onos in current case[1]) If that happen then it return failure status code to the propose-updates job and fail that job - https://zuul.openstack.org/builds?job_name=propose-updates&project=openstack%2Fdevstack&skip=0 It is better not to raise the 500 error in this script and just ignore those repo to process further to detect the plugin. [1] https://zuul.openstack.org/build/dba0aa41d145472397916dfcd13948de/log/job-output.txt#2442 Change-Id: Ibca0a2aac404161340e8fc00170018eecf5c8326
diff --git a/tools/generate-devstack-plugins-list.py b/tools/generate-devstack-plugins-list.py index 1cacd06..bc28515 100644 --- a/tools/generate-devstack-plugins-list.py +++ b/tools/generate-devstack-plugins-list.py
@@ -73,8 +73,11 @@ s = requests.Session() # sometimes gitea gives us a 500 error; retry sanely # https://stackoverflow.com/a/35636367 +# We need to disable raise_on_status because if any repo endup with 500 then +# propose-updates job which run this script will fail. retries = Retry(total=3, backoff_factor=1, - status_forcelist=[ 500 ]) + status_forcelist=[ 500 ], + raise_on_status=False) s.mount('https://', HTTPAdapter(max_retries=retries)) found_plugins = filter(functools.partial(has_devstack_plugin, s), projects)