commit 6f0017161f76ffecd1ee489bcb33462729ad96e6
author Euan Harris <euan.harris@citrix.com> Wed Jul 10 16:30:31 2013 +0100
committer Euan Harris <euan.harris@citrix.com> Thu Jul 11 12:05:44 2013 +0100
tree a7567796de6780943b9497734d97ab6be054723f
parent 314ae87a911b457590cd268a6d50872c957de343

xenapi: Exit immediately if zipball download fails

If install_os_domU.sh fails to download the Xapi plugins zipball
correctly it ignores the error and continues the installation.
This could damage the hypervisor's filesystem, as it may delete
files or overwrite them with garbage.

Change-Id: I9f6dc31b977592e2818e37b2d310c2a5dc477364
Fixes: bug #1195640

tools/xen/functions

diff --git a/tools/xen/functions b/tools/xen/functions
index 4e37554..e5a7531 100644
--- a/tools/xen/functions
+++ b/tools/xen/functions
@@ -40,11 +40,11 @@
     local LOCAL_ZIPBALL=$(mktemp)
     local EXTRACTED_FILES=$(mktemp -d)
 
-    (
+    {
         wget -nv $ZIPBALL_URL -O $LOCAL_ZIPBALL --no-check-certificate
         unzip -q -o $LOCAL_ZIPBALL -d $EXTRACTED_FILES
         rm -f $LOCAL_ZIPBALL
-    ) >&2
+    } >&2
 
     echo "$EXTRACTED_FILES"
 }