)]}'
{
  "commit": "88b84094ec1e2a18b6edba91f510cae53bc9c821",
  "tree": "c4d3192ca6540c97b132d1c03d6593a968d9bd56",
  "parents": [
    "7eef546f8a471a3709ff099955787d444e43eadf"
  ],
  "author": {
    "name": "Roman Podoliaka",
    "email": "rpodolyaka@mirantis.com",
    "time": "Tue Feb 07 13:34:12 2017 +0200"
  },
  "committer": {
    "name": "Roman Podoliaka",
    "email": "rpodolyaka@mirantis.com",
    "time": "Tue Feb 07 18:01:25 2017 +0200"
  },
  "message": "mysql: set default sql_mode to TRADITIONAL\n\nWe currently use a more permisive STRICT_ALL_TABLES mode, but that\u0027s\nnot what modern MySQL versions default to (i.e. TRADITIONAL):\n\nhttps://dev.mysql.com/doc/refman/5.7/en/sql-mode.html#sql-mode-changes\n\n(non-Devstack deployments will most likely use TRADITIONAL as well)\n\nDue to the fact that we default to TRADITIONAL in oslo.db, this\nproduces annoying warnings on MySQL 5.7 versions we use in the gate:\n\n    Warning: (3090, u\"Changing sql mode \u0027NO_AUTO_CREATE_USER\u0027 is\n              deprecated. It will be removed in a future release.\")\n\nhttps://git.openstack.org/cgit/openstack/oslo.db/tree/oslo_db/options.py#n49\n\nUnlike STRICT_ALL_TABLES, TRADITIONAL mode includes NO_AUTO_CREATE_USER,\nand MySQL emits this warning on switching it on:\n\nhttps://dev.mysql.com/worklog/task/?id\u003d8326\n\nSo we have two options here:\n\n1) make oslo.db default to STRICT_ALL_TABLES\n2) make Devstack default to TRADITIONAL\n\nThe latter seems to be more appropriate as:\n\n1) it\u0027s what modern MySQL versions default to\n2) it\u0027s what people are actually using, if they do not override the\n   oslo.db default\n3) it\u0027s more strict\n\nCloses-Bug: #1652452\n\nChange-Id: Ie6d823c9f8465ac9f2ce4825929d1a50438fab45\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "89ae082c81684d0a10905add83c3435d881ced30",
      "old_mode": 33188,
      "old_path": "lib/databases/mysql",
      "new_id": "7bbcace399294ca022aca5a97e8678a7ecd4c699",
      "new_mode": 33188,
      "new_path": "lib/databases/mysql"
    }
  ]
}