Enforce function declaration format in bash8
Check that function calls look like ^function foo {$ in bash8, and fix
all existing failures of that check. Add a note to HACKING.rst
Change-Id: Ic19eecb39e0b20273d1bcd551a42fe400d54e938
diff --git a/lib/stackforge b/lib/stackforge
index 5fa4570..dca08cc 100644
--- a/lib/stackforge
+++ b/lib/stackforge
@@ -34,7 +34,7 @@
# ------------
# install_stackforge() - Collect source and prepare
-function install_stackforge() {
+function install_stackforge {
# TODO(sdague): remove this once we get to Icehouse, this just makes
# for a smoother transition of existing users.
cleanup_stackforge
@@ -47,7 +47,7 @@
}
# cleanup_stackforge() - purge possibly old versions of stackforge libraries
-function cleanup_stackforge() {
+function cleanup_stackforge {
# this means we've got an old version installed, lets get rid of it
# otherwise python hates itself
for lib in wsme pecan; do