commit e769348882ea3e6b4465e3a6af72029633b2485e
author Ian Wienand <iwienand@redhat.com> Mon Feb 11 12:26:03 2019 +1100
committer Clark Boylan <clark.boylan@gmail.com> Fri Mar 29 11:20:14 2019 -0700
tree b4c3c511b3b4ee94ca7dcdc3cbac7ea27bfeaa7f
parent 8bdbf850967b90ebdca428247bb93ad2eb6478c0

Quote devstack_localrc arguments

If you have

 devstack_localrc:
   ARGUMENT: "argument with spaces"

The quotes get lost during YAML processing and the resulting file has

  ARGUMENT=argument with spaces

which is a shell error.

Quote all arguments to avoid this sort of thing.

Change-Id: Ia63a53d745dfea7262bcdb5d46425f431c3ccfe5

roles/write-devstack-local-conf/library/devstack_local_conf.py

diff --git a/roles/write-devstack-local-conf/library/devstack_local_conf.py b/roles/write-devstack-local-conf/library/devstack_local_conf.py
index 8df8dea..3a8cd58 100644
--- a/roles/write-devstack-local-conf/library/devstack_local_conf.py
+++ b/roles/write-devstack-local-conf/library/devstack_local_conf.py
@@ -252,7 +252,7 @@
         if localrc:
             vg = VarGraph(localrc)
             for k, v in vg.getVars():
-                self.localrc.append('{}={}'.format(k, v))
+                self.localrc.append('{}="{}"'.format(k, v))
                 if k == 'LIBS_FROM_GIT':
                     lfg = True
                 elif k == 'TEMPEST_PLUGINS':