commit ee37d20f80d3a4871edd17a16c12e8ea5f0afadf
author Sean Dague <sean@dague.net> Wed Feb 08 11:24:31 2017 -0500
committer Sean Dague <sean@dague.net> Mon Feb 13 14:06:03 2017 +0000
tree cd8d091500bdb1c53164f67a5104f05b4f969726
parent 7eef546f8a471a3709ff099955787d444e43eadf

pass role by name not id

Change-Id: Ie67758bed3563c9a46a5180eaa9c8d47721fffd8

lib/keystone

diff --git a/lib/keystone b/lib/keystone
index 474af8b..c1a6d43 100644
--- a/lib/keystone
+++ b/lib/keystone
@@ -384,8 +384,7 @@
     admin_project=$(openstack project show "admin" -f value -c id)
     local admin_user
     admin_user=$(openstack user show "admin" -f value -c id)
-    local admin_role
-    admin_role=$(openstack role show "admin" -f value -c id)
+    local admin_role="admin"
 
     get_or_add_user_domain_role $admin_role $admin_user default
 
@@ -403,13 +402,20 @@
     get_or_create_role ResellerAdmin
 
     # The Member role is used by Horizon and Swift so we need to keep it:
-    local member_role
-    member_role=$(get_or_create_role "Member")
+    local member_role="member"
+
+    # Captial Member role is legacy hard coded in Horizon / Swift
+    # configs. Keep it around.
+    get_or_create_role "Member"
+
+    # The reality is that the rest of the roles listed below honestly
+    # should work by symbolic names.
+    get_or_create_role $member_role
 
     # another_role demonstrates that an arbitrary role may be created and used
     # TODO(sleepsonthefloor): show how this can be used for rbac in the future!
-    local another_role
-    another_role=$(get_or_create_role "anotherrole")
+    local another_role="anotherrole"
+    get_or_create_role $another_role
 
     # invisible project - admin can't see this one
     local invis_project