commit fa55cb5f978f6bd9476f1b09a94c8d6aaa18beb4
author Mathieu Mitchell <mmitchell@iweb.com> Tue Jan 24 11:32:24 2017 -0500
committer Mathieu Mitchell <mat128@gmail.com> Tue Aug 01 18:22:35 2017 +0000
tree b621a0326f2441411f2f553c041a2cbaa797d4c8
parent 07d612e4609367aa820d519a2ca7100b087bd25e

Ensure valid service names are passed to stack_install_service

Currently, stack_install_service will accept any service name. This is
problematic because a project plugin can pass an invalid name without
noticing. This has been the case in ironic-inspector[0].

This commit ensures that stack_install_service will not silently fail
when passing an invalid service name.

[0] https://review.openstack.org/#/c/424680/

Change-Id: I1a8105bdbaf4aecb630df08da416808bf7180824
Closes-Bug: #1659042

lib/stack

diff --git a/lib/stack b/lib/stack
index f09ddce..bada26f 100644
--- a/lib/stack
+++ b/lib/stack
@@ -33,5 +33,8 @@
         if [[ ${USE_VENV} = True && -n ${PROJECT_VENV[$service]:-} ]]; then
             unset PIP_VIRTUAL_ENV
         fi
+    else
+        echo "No function declared with name 'install_${service}'."
+        exit 1
     fi
 }