gifn-apply: drop the pylint test environment
Ruff does that now.
Change-Id: I0e5c8a9b3eedbe0ccc96927ff915965a4c43597c
diff --git a/tools/git-if-needed/pyproject.toml b/tools/git-if-needed/pyproject.toml
index ce37834..1b060b7 100644
--- a/tools/git-if-needed/pyproject.toml
+++ b/tools/git-if-needed/pyproject.toml
@@ -31,41 +31,5 @@
strict = true
python_version = "3.8"
-[tool.pylint]
-py-version = "3.8"
-load-plugins = [
- "pylint.extensions.bad_builtin",
- "pylint.extensions.broad_try_clause",
- "pylint.extensions.check_elif",
- "pylint.extensions.code_style",
- "pylint.extensions.comparetozero",
- "pylint.extensions.comparison_placement",
- "pylint.extensions.confusing_elif",
- "pylint.extensions.consider_refactoring_into_while_condition",
- "pylint.extensions.consider_ternary_expression",
- "pylint.extensions.dict_init_mutate",
- "pylint.extensions.docparams",
- "pylint.extensions.docstyle",
- "pylint.extensions.dunder",
- # "pylint.extensions.empty_comment", # the license text triggers this
- "pylint.extensions.emptystring",
- "pylint.extensions.eq_without_hash",
- "pylint.extensions.for_any_all",
- "pylint.extensions.magic_value",
- "pylint.extensions.mccabe",
- "pylint.extensions.no_self_use",
- "pylint.extensions.overlapping_exceptions",
- "pylint.extensions.private_import",
- "pylint.extensions.redefined_loop_name",
- "pylint.extensions.redefined_variable_type",
- "pylint.extensions.set_membership",
- "pylint.extensions.typing",
- "pylint.extensions.while_used",
-]
-disable = [
- # Clarity
- "consider-using-assignment-expr",
-]
-
[tool.test-stages]
stages = ["@check and @quick and not @manual", "@check and not @manual", "@tests and not @manual"]
diff --git a/tools/git-if-needed/python/gifn_apply/git.py b/tools/git-if-needed/python/gifn_apply/git.py
index 8650fd6..931e930 100644
--- a/tools/git-if-needed/python/gifn_apply/git.py
+++ b/tools/git-if-needed/python/gifn_apply/git.py
@@ -84,8 +84,8 @@
fields: Final = line.split()
# The magic value will go away once we can use structural pattern matching
if (
- len(fields) != 2 # noqa: PLR2004 # pylint: disable=magic-value-comparison
- or fields[0] != "Change-Id:" # pylint: disable=magic-value-comparison
+ len(fields) != 2 # noqa: PLR2004
+ or fields[0] != "Change-Id:"
or not fields[1].startswith("I")
):
raise GitError(f"Unexpected `git log` ouput for change IDs: {line!r}")
diff --git a/tools/git-if-needed/tox.ini b/tools/git-if-needed/tox.ini
index fc858e4..ce41c10 100644
--- a/tools/git-if-needed/tox.ini
+++ b/tools/git-if-needed/tox.ini
@@ -8,7 +8,6 @@
ruff-all
black
mypy
- pylint
unit-tests
functional-cinder
isolated_build = true
@@ -47,16 +46,6 @@
commands =
mypy -- {[defs]pyfiles}
-[testenv:pylint]
-skip_install = True
-tags =
- check
-deps =
- -r python/requirements/test.txt
- pylint >= 2.16, < 2.17
-commands =
- pylint -- {[defs]pyfiles}
-
[testenv:ruff]
skip_install = True
tags =