Use sequence directly instead of using len()
This commit makes to use sequence directly instead of using
len(SEQUENCE). The original code works correctly, and it's really
straight forward. However, PEP8 recommends like below[1]. And it
makes code more simple, too.
```
For sequences, (strings, lists, tuples), use the fact that empty
sequences are false.
Yes: if not seq:
if seq:
No: if len(seq):
if not len(seq):
```
[1] https://www.python.org/dev/peps/pep-0008/#programming-recommendations
Change-Id: I8d41e16d82b1b3860a98e5217cb7a541fc83b907
diff --git a/tempest/test.py b/tempest/test.py
index 052033d..ca41e08 100644
--- a/tempest/test.py
+++ b/tempest/test.py
@@ -139,7 +139,7 @@
'object': CONF.object_storage_feature_enabled.discoverable_apis,
'identity': CONF.identity_feature_enabled.api_extensions
}
- if len(config_dict[service]) == 0:
+ if not config_dict[service]:
return False
if config_dict[service][0] == 'all':
return True
@@ -160,7 +160,7 @@
"""
filters = CONF.compute_feature_enabled.scheduler_available_filters
- if len(filters) == 0:
+ if not filters:
return False
if 'all' in filters:
return True
@@ -634,7 +634,7 @@
"""
if msg is None:
msg = "sequence or collection is not empty: %s" % items
- self.assertEqual(0, len(items), msg)
+ self.assertFalse(items, msg)
def assertNotEmpty(self, items, msg=None):
"""Asserts whether a sequence or collection is not empty
@@ -645,4 +645,4 @@
"""
if msg is None:
msg = "sequence or collection is empty."
- self.assertGreater(len(items), 0, msg)
+ self.assertTrue(items, msg)