Peter Pentchev | 5a9f8a6 | 2023-12-06 10:40:18 +0200 | [diff] [blame] | 1 | From 0912d760d1329eb3e1ccfc79b99a916e810d0f20 Mon Sep 17 00:00:00 2001 |
Peter Pentchev | acaaa38 | 2023-02-28 11:26:13 +0200 | [diff] [blame] | 2 | From: Peter Penchev <openstack-dev@storpool.com> |
| 3 | Date: Mon, 13 Feb 2023 11:15:27 +0200 |
Peter Pentchev | 5a9f8a6 | 2023-12-06 10:40:18 +0200 | [diff] [blame] | 4 | Subject: [PATCH 01/10] StorPool: cosmetic: comment headings instead of empty |
Peter Pentchev | acaaa38 | 2023-02-28 11:26:13 +0200 | [diff] [blame] | 5 | lines |
| 6 | |
| 7 | Instead of using empty lines to separate semantically different |
| 8 | sections of the driver capabilities / pools status dictionary, |
| 9 | put in comments describing the sections. |
| 10 | |
| 11 | Change-Id: Id919c9d4a854101c9635c53af4e11d5ea22ea697 |
| 12 | --- |
| 13 | cinder/volume/drivers/storpool.py | 5 +++-- |
| 14 | 1 file changed, 3 insertions(+), 2 deletions(-) |
| 15 | |
Peter Pentchev | ea35446 | 2023-07-18 11:15:56 +0300 | [diff] [blame] | 16 | diff --git a/cinder/volume/drivers/storpool.py b/cinder/volume/drivers/storpool.py |
Peter Pentchev | 5a9f8a6 | 2023-12-06 10:40:18 +0200 | [diff] [blame] | 17 | index 47685cb3f..d42d1c68c 100644 |
Peter Pentchev | acaaa38 | 2023-02-28 11:26:13 +0200 | [diff] [blame] | 18 | --- a/cinder/volume/drivers/storpool.py |
| 19 | +++ b/cinder/volume/drivers/storpool.py |
Peter Pentchev | 5a9f8a6 | 2023-12-06 10:40:18 +0200 | [diff] [blame] | 20 | @@ -302,14 +302,15 @@ class StorPoolDriver(driver.VolumeDriver): |
Peter Pentchev | acaaa38 | 2023-02-28 11:26:13 +0200 | [diff] [blame] | 21 | ) for t in templates] |
| 22 | |
| 23 | self._stats = { |
| 24 | + # Basic driver properties |
| 25 | 'volume_backend_name': self.configuration.safe_get( |
| 26 | 'volume_backend_name') or 'storpool', |
| 27 | 'vendor_name': 'StorPool', |
| 28 | 'driver_version': self.VERSION, |
| 29 | 'storage_protocol': constants.STORPOOL, |
| 30 | - |
| 31 | + # Driver capabilities |
Peter Pentchev | acaaa38 | 2023-02-28 11:26:13 +0200 | [diff] [blame] | 32 | 'sparse_copy_volume': True, |
| 33 | - |
| 34 | + # The actual pools data |
| 35 | 'pools': pools |
| 36 | } |
| 37 | |
Peter Pentchev | ea35446 | 2023-07-18 11:15:56 +0300 | [diff] [blame] | 38 | -- |
Peter Pentchev | 5a9f8a6 | 2023-12-06 10:40:18 +0200 | [diff] [blame] | 39 | 2.42.0 |
Peter Pentchev | ea35446 | 2023-07-18 11:15:56 +0300 | [diff] [blame] | 40 | |